djib/PDMameUpdate
2
0
Fork 1
Code Issues Pull Requests Releases Activity

master #1

Merged
djib merged 3 commits from sebastian404/PDMameUpdate:master into master 2019-09-28 08:25:24 +02:00
Conversation 5 Commits 3 Files Changed 1
+9 -6
sebastian404 commented 2019-09-25 19:26:11 +02:00
Contributor
Copy Link
Copy Source

WIP Some suggested 'fixes' for you.

WIP Some suggested 'fixes' for you.
👍 1
djib reviewed 2019-09-25 21:41:48 +02:00
djib left a comment
Owner
Copy Link
Copy Source

Please provide an updated template.json. Also, could you update the config value to mame-directory with a dash?

Please provide an updated template.json. Also, could you update the config value to mame-directory with a dash?
sebastian404 commented 2019-09-26 01:18:47 +02:00
Author
Contributor
Copy Link
Copy Source

mame_directory is already defined in the template.json, it's used in fetch_local_torrents and update_torrents.

I put my torrents in a 'MAME' subfolder seperate from the other torrents, so I need to set download_dir, otherwise it uses transmission's default directory.

mame_directory is already defined in the template.json, it's used in fetch_local_torrents and update_torrents. I put my torrents in a 'MAME' subfolder seperate from the other torrents, so I need to set download_dir, otherwise it uses transmission's default directory.
djib commented 2019-09-26 11:44:22 +02:00
Owner
Copy Link
Copy Source

Sorry I meant sharing your updated config.template.json in your PR.

Sorry I meant sharing your updated `config.template.json` in your PR.
sebastian404 commented 2019-09-28 01:10:09 +02:00
Author
Contributor
Copy Link
Copy Source

I dont understand your request, 'mame_directory' is in config.template.json it is part of the original script

https://djib.fr/djib/PDMameUpdate/src/branch/master/config.template.json

it is the directory the scipt looks in for torrents in fetch_local_torrents, and then again in update_torrents to rename the directory.

I dont understand your request, 'mame_directory' is in config.template.json it is part of the original script https://djib.fr/djib/PDMameUpdate/src/branch/master/config.template.json it is the directory the scipt looks in for torrents in fetch_local_torrents, and then again in update_torrents to rename the directory.
djib commented 2019-09-28 08:24:26 +02:00
Owner
Copy Link
Copy Source

Well I'll be damned, I totally skipped that. Sorry for the trouble and thanks for contributing.

Well I'll be damned, I totally skipped that. Sorry for the trouble and thanks for contributing.
😕 1
djib closed this pull request 2019-09-28 08:25:24 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
djib
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
djib (Jean-Baptiste Hétier)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: djib/PDMameUpdate#1