djib/PDMameUpdate
2
0
Fork 1
Code Issues Pull Requests Releases Activity

Only newest version of torrents with multiple versions are added #2

Merged
djib merged 1 commits from sebastian404/PDMameUpdate:master into master 2019-10-29 12:45:27 +01:00
Conversation 1 Commits 1 Files Changed 1 +6 -3
sebastian404 commented 2019-10-29 12:03:09 +01:00
Contributor
Copy Link

currently both the 0.215 & 0.214 torrents are listed on the PD RSS feed

INFO - Opening PleasureDome RSS feed
INFO - Found: HBMAME 0.215 ROMs (merged)
INFO - Found: HBMAME 0.215 ROMs (bios-devices)
INFO - Found: HBMAME 0.215 Rollback ROMs
INFO - Found: HBMAME 0.214 ROMs (merged)
INFO - Found: HBMAME 0.214 ROMs (bios-devices)
INFO - Found: HBMAME 0.214 Rollback ROMs

as the script loops the full feed, it will pick out both versions, updating the torrents array for all it finds, and the result is it will overwrite the first entry with the older version.

I have added check to make sure the remote-version is not already defined, so it will only use the first (newest) entry it finds.

There is probably a more elegant/robust way to do this, but this works :)

currently both the 0.215 & 0.214 torrents are listed on the PD RSS feed INFO - Opening PleasureDome RSS feed INFO - Found: HBMAME 0.215 ROMs (merged) INFO - Found: HBMAME 0.215 ROMs (bios-devices) INFO - Found: HBMAME 0.215 Rollback ROMs INFO - Found: HBMAME 0.214 ROMs (merged) INFO - Found: HBMAME 0.214 ROMs (bios-devices) INFO - Found: HBMAME 0.214 Rollback ROMs as the script loops the full feed, it will pick out both versions, updating the torrents array for all it finds, and the result is it will overwrite the first entry with the older version. I have added check to make sure the remote-version is not already defined, so it will only use the first (newest) entry it finds. There is probably a more elegant/robust way to do this, but this works :)
👍 1
djib closed this pull request 2019-10-29 12:45:27 +01:00
djib commented 2019-10-29 12:45:41 +01:00
Owner
Copy Link

Thanks.

Thanks.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
djib
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: djib/PDMameUpdate#2
No description provided.
Delete Branch "sebastian404/PDMameUpdate:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?